[texinfo-pretest] texinfo 4.7.91: Fix warnings
Stepan Kasal
kasal at ucw.cz
Fri Dec 10 09:23:19 EST 2004
Hello Andreas,
thank you for the patch.
Are you sure that there are no architectures where you change actually
brings new warnings?
Perhaps we should accept your patch only after the release.
A few comments, not related too much:
On Thu, Dec 09, 2004 at 03:52:11PM +0100, Andreas Schwab wrote:
> printf_to_message_buffer (completions_found_index == 1
> ? (char *) _("One completion:\n")
> : (char *) _("%d completions:\n"),
this should be handled better, as explained in "(gettext)Plural forms".
> syntax_error (filename, lnum,
> (char *) _("NUL character (^%c) not permitted"),
> + (void *) (long) c, NULL, NULL, NULL);
Well, all these functions should use varargs. The implementation of
error() in gnulib could probably serve as template.
In both cases, I know where to learn from, but have no experience.
I'm afraid I won't have time to volunteer for this in any reasonable
timeframe...
Have a nice day,
Stepan
More information about the texinfo-pretest
mailing list